-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x #174
4.x #174
Conversation
I'm also trying to remove the |
Why I thought I would need that?!
This looks great. Thank’s so much @robsonsobral |
...avoid conflicts with out reserved word. https://sass-lang.com/documentation/modules/math#is-unitless
@scottkellum , hi! Bom dia! What do you think of the suggestion on the last commit? It is far too common for me that designers use 90px instead 92px, as our previous agreement about the modular scale. (Also, it's easier to write the target size, than keep looking at a table to find the right step.) |
Oooh wow I really love this idea! This is fantastic |
...because that's already the default settings
...in a shorter way than the previous one
e116e6b
to
53800c2
Compare
While I try to figure out what awesome things ( 😳 ) you mentioned on twitter, @scottkellum , could you tell me what you think of rename the I added the possibility to use the syntax Also, the named ratios can now be used as a simple string, instead of a prefixed reference:
The override of settings is my next step. I'm looking at my Bringhurst, Muller-Brochmann and Tschichold books for something that could be useful. Thank you! |
OK! Finally, we have 100% of code coverage! The use of git diff for tests is compromised by the Settings can be override after initial loading by the use of the mixin Should the override of settings reset the value of The responsive mixin could allow inline settings like the Do you mind of a I have some thoughts yet about the responsive part. |
Thanks so much @robsonsobral ! Getting the target stuff in here like I'm going to merge into my 4.x branch to better play with what you have and respond to your questions. |
@robsonsobral a few issues here. True was not resolving for me initially. I had to make the path be Two issues with setup:
|
Here is a branch where I was poking around: https://github.com/modularscale/modularscale-sass/pulls |
Oh, I totally agree on the settings. I've detected their redundancy. However, I wasn't sure I made it more evident or created it as I saw On the Sass-True, it's weird it doesn't load. Maybe my Sass installation is outdated. I gonna check it out. Also, I gonna take a look at default settings. I saw it so many times on your code, that maybe I got confuse. I'm sorry. |
@robsonsobral all good thank you for your work on this! I'll look at my sass version as well |
I updated from "1.34.0" to "1.42.1". If you want, we can work together on code. I promise to do a |
@scottkellum , may I follow this path? What do you think? Does it help?