fix(runtime): correct type structure for preload remote hook (#2515)

module-federation · May 21, 2024 · 103cd07 · 103cd07
1 parent d1d9809
commit 103cd07
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/.changeset/bright-items-draw.md b/.changeset/bright-items-draw.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/runtime': patch
+---
+
+fix types for beforePreloadRemote args hook
diff --git a/packages/runtime/src/remote/index.ts b/packages/runtime/src/remote/index.ts
@@ -92,11 +92,15 @@ export class RemoteHandler {
       ],
       void | unknown
     >('errorLoadRemote'),
-    beforePreloadRemote: new AsyncHook<{
-      preloadOps: Array<PreloadRemoteArgs>;
-      options: Options;
-      origin: FederationHost;
-    }>(),
+    beforePreloadRemote: new AsyncHook<
+      [
+        {
+          preloadOps: Array<PreloadRemoteArgs>;
+          options: Options;
+          origin: FederationHost;
+        },
+      ]
+    >('beforePreloadRemote'),
     generatePreloadAssets: new AsyncHook<
       [
         {
@@ -195,7 +199,7 @@ export class RemoteHandler {
     const { host } = this;
 
     await this.hooks.lifecycle.beforePreloadRemote.emit({
-      preloadOptions,
+      preloadOps: preloadOptions,
       options: host.options,
       origin: host,
     });