@module-federation/node doesn't revalidate express

[ilyassab]

Hello
Awesome node plugin but I have troubles while revalidation.

Steps to reproduce problem:

1. Download this repo https://github.com/module-federation/module-federation-examples/tree/master/server-side-rendering.
2. Update @module-federation/node to 0.9.4
3. Change webpack output from

output: {
    path: path.resolve(__dirname, "../dist/server"),
    filename: "[name].js",
    libraryTarget: "commonjs-module",
  }

to

output: {
    path: path.resolve(__dirname, "../dist/server"),
    filename: "[name].[chunkhash].js",
    libraryTarget: "commonjs-module",
  }

in remote1 and remote2 projects
4) Add new route '/revalidate' to shell like this:

app.get('/revalidate', async (req, res, next) => {
    revalidate();
    res.send();
  });

5. Build and serve all the repos -> All is fine localhost:3000 starts serve all remotes and local files
6. Change code in remote1 and rebuild remote1 project
7. If you go to route '/revalidate', you will see this in server console

remote1 hash is different - must hot reload server

but nothing happens.
Only "fail while hydrating" errors in browser console

If I add route '/revalidation' like this

global.clearRoutes = () => {
    app._router.stack = app._router.stack.filter(
        k => !(k && k.route && k.route.path)
    )
  }

revalidate().then((shouldReload) => {
      if(shouldReload) {
        global.clearRoutes()
      }
    });

Express starts shows Get errors, because it has no routes after clearRoutes :)

What am I doing wrong?

[ScriptedAlchemy]

You need to implement your own revalidation mechanism - I just provide the hook

[ScriptedAlchemy]

If youre hitting revalidation after hot reload happens then you might be clearing the route stack out of sync so nothing gets reloaded into express. I do have standard ssr apps that demo this reloading concept, might be worth looking at those or sending me a repo

[github-actions]

Stale issue message