Enhanced - remove import require statements for swc interop #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussellCanfield
changed the title
Merge? |
ScriptedAlchemy
deleted the
rcanfield-node-sync-bytedance-ImportRequire
branch
|
🎉 This PR is included in version 8.1.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ScriptedAlchemy - it turns out the import require syntax can be worked around if we use the swc interop helper:
https://swc.rs/docs/configuration/modules#nointerop
We can technically just remove noInterop from .swcrc and it'll work but I made them explicit for now. You can see the difference in the compiled code where they wrap require statements in their wrapper. But this removes the need to import = require().
Tested with start:node and start:next