-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Node Federation Runtime Plugin #2013
Open
ScriptedAlchemy
wants to merge
105
commits into
main
Choose a base branch
from
feat/node-runtime-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e0cef8.
# Conflicts: # packages/node/src/utils/flush-chunks.ts
Base automatically changed from
debugging-container-init
to
feat/use-runtime-script-load
January 23, 2024 07:17
…eat/node-runtime-plugin
ScriptedAlchemy
force-pushed
the
feat/node-runtime-plugin
branch
from
April 19, 2024 05:41
67dafed
to
b12f149
Compare
# Conflicts: # .github/workflows/build-and-test.yml # packages/enhanced/src/lib/container/AsyncBoundaryPlugin.ts # packages/enhanced/src/lib/container/runtime/getFederationGlobal.ts
# Conflicts: # .github/workflows/build-and-test.yml # apps/3000-home/package.json # pnpm-lock.yaml
🦋 Changeset detectedLatest commit: 045b228 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/node/src/plugins/NodeFederationPlugin.ts # packages/node/src/plugins/UniversalFederationPlugin.ts # packages/node/src/runtimePlugin.ts
ScriptedAlchemy
force-pushed
the
feat/node-runtime-plugin
branch
from
April 24, 2024 21:36
0de55cd
to
1b2003e
Compare
# Conflicts: # apps/node-host/webpack.config.js # packages/nextjs-mf/src/plugins/NextFederationPlugin/apply-client-plugins.ts # pnpm-lock.yaml
# Conflicts: # .github/workflows/build-and-test.yml # .gitignore # apps/node-host/src/bootstrap.js # package.json # pnpm-lock.yaml
# Conflicts: # packages/enhanced/src/lib/container/AsyncBoundaryPlugin.ts # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces webpack based plugin with pure runtime plugin
This runtime plugin replaces the need for compiler-specific integrations for node federation.
It does so by applying the needed runtime modules and handlers in the runtime plugin instead of in a template.
PR introduces a significant change to the Node.js implementation. The script loading utility, previously used by webpack to load external chunks, has been converted into a runtime plugin for Node.js. This change enhances the ability to load scripts dynamically at runtime, providing greater flexibility and efficiency in the application.
Related Issue
Types of changes
Checklist