Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs-mf): do not crash if host is not next #2604

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

ScriptedAlchemy
Copy link
Member

Description

Fix issue where next as remote crashes when consumed by non next host

Related Issue

#2530

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 3010520

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@module-federation/nextjs-mf Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 3010520
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6669265655d92c0008194a50
😎 Deploy Preview https://deploy-preview-2604--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy merged commit 0f4d9e2 into main Jun 12, 2024
9 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the next-runtime-plugin-mixed-host branch June 12, 2024 05:38
@2heal1 2heal1 mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant