Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vite #4086

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Remove vite #4086

merged 2 commits into from
Jun 21, 2024

Conversation

ScriptedAlchemy
Copy link
Member

No description provided.

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-example-dsl 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:54pm
medusa-example-home 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:54pm
medusa-example-nav 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:54pm
medusa-example-search 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:54pm
medusa-example-utils 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:54pm

@ScriptedAlchemy ScriptedAlchemy merged commit cd5ef16 into master Jun 21, 2024
3 of 8 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the remove-vite branch June 21, 2024 21:54
Copy link

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ScriptedAlchemy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KaiVolland
Copy link

@ScriptedAlchemy can you explain why you removed these examples? Did they move? Will there be a replacement? Is vite no longer supported?

@chenjiahan
Copy link

@KaiVolland Hi, I found a twitter about this change, hope it helps you understand the background

https://x.com/ScriptedAlchemy/status/1804305807879868793

@KaiVolland
Copy link

Perfect. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow-failure Workflow is failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants