feat: Move Repo to NX #154
Conversation
|
Typescript migration can be a followup PR. |
|
I'm not migrating to TS yet.. We are going with JS first, so it should be fairly easy to merge PR #103 with a rebase. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hmm I see, Perhaps I'll wait for these PR's to be Merged. |
|
If these were git move operations, then IDE might be able to pick up there was movement and not cause a major issue |
|
I don't think we can perform a |
|
Ahhh gotcha. Damn Okay, well I guess that we will need to merge all our work (SSR too) them let you cut us over to nx and then resume working on it :) I'll follow up tomorrow. Just need to add default option to disable SSR so we can merge it without it impacting anyone |
|
@ScriptedAlchemy I'm thinking instead of a separate repo for Since nextjs-mf is heavily dependent on the mf-node package, they both living in the same repo makes our work seamless. Otherwise we have to deploy the changes from mf-node first and then consume it on the nextjs-mf later.. I know there are other methods like |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
| @@ -1,51 +1,64 @@ | |||
| { | |||
There was a problem hiding this comment.
@pavandv what about "dev": "rm -rf lib && concurrently \"yarn sync-files --watch\" \"yarn compile --watch\" \"yarn demo\"", script?
How to run repo in dev mode?
There was a problem hiding this comment.
Figured a way to resolve the issue in another way.. Working on it.
There was a problem hiding this comment.
To serve applications, one has to run npm/yarn start.
To build packages, one has to run npm run build or yarn build
|
@pavandv could we please discuss changes in proper review comment threads? After reaching an agreement we will close them. I hide several of our comments from the main thread because very fast it will become messy. |
packages/shared/src/index.ts
Outdated
| @@ -18,3 +18,17 @@ module.exports = { | |||
| '/wrong-entry', | |||
| ], | |||
| }; | |||
|
|
|||
| export const getRemotes = (isServer: boolean) => { | |||
There was a problem hiding this comment.
Could we please completely remove this package?
getRemotes is never used.
mfRouters can be placed directly in apps/ folder OR its content can be copy pasted in every _app.tsx file. I think 2nd option is better.
mfRemote is designed for generating in runtime (it can be dynamic and contains different URLs for remotes), and putting it in the package completely broke and hide this idea from newcomers.
|
Okay this is great. We will start working on this branch and patch over the lastes from main into NX |
@ScriptedAlchemy Patched all the changes from Main branch. |
|
how does this thing build? i see rollup is no more :O |
|
It uses Typescript Compiler (TSC) to build. Basically it transpiles all the files to We can also use |
…po' into 126-move-repo-to-nx-based-monorepo
* feat: add utils and verdaccio * chore: drop verdaccio cache
|
🎉 This PR is included in version 1.0.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR addresses #126
nextjs-mfpackage to Build & PublishSWCto build the packagenodepackage in NX for Build & PublishTSCto build the packageDemosto applications using@nrwl/nextpackageHomeappShopeappCheckoutappfixes #199, fixes #205, fixes #144, closes #126