New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined constant error (php8) and manager breaking error if the service is unavailable #339

Merged

theboxer merged 2 commits into modxcms:for-3 from modmore:patch-modx3rc1

Jan 24, 2022

Contributor

Mark-H commented Jan 23, 2022

First issue is a typo causing a (handled) error Undefined constant "to" on PHP8
Second issue happens when, for example, you try to set up the repository from git manually and enter the wrong path in the namespace. That causes the service to not be available, and a fatal error occurs that breaks the entire manager.

Mark-H added 2 commits

January 23, 2022 03:22


          Fix "undefined constant to" error on PHP8

aeb9ed3


          Fix fatal manager-breaking error when for whatever reason the collect…

5faaf5a

…ions service is not available

theboxer merged commit ce15ac6 into modxcms:for-3

Member

theboxer commented Jan 24, 2022

Thanks!

Mark-H deleted the patch-modx3rc1 branch

January 24, 2022 19:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment