Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slimbox not working properly with Gallery 1.7 #55

Closed
radomirK opened this issue Dec 30, 2014 · 2 comments
Closed

Slimbox not working properly with Gallery 1.7 #55

radomirK opened this issue Dec 30, 2014 · 2 comments
Labels

Comments

@radomirK
Copy link

I have recently updated from Gallery 1.5.2 to version 1.7 and suddenly Slimbox plugin stopped adjusting the final height and width of images to fit to the screen. It seems to me that it just started to ingore the settings of imageHeight and imageWidth. With the lower version of Gallery it worked just fine. As I checked, there is no explicit way to set maxHeight and maxWidth in slimbox itself.

I wonder what has changed or what am I doing wrong? Unfortunately I was not even able to go back the lower version so now I have to resize the images manually and during the upload to a given size, which is not a neat solution for multiple devices.

I have also a remark about "next" and "prev" buttons in Slimbox. They do not work with any released version of Gallery, since a line in core/components/gallery/model/gallery/plugins/slimbox.class.php has to be changed from
$scriptProperties['linkAttributes'] = $this->modx->getOption('linkAttributes',$scriptProperties,'').' rel="lightbox"';
to
$scriptProperties['linkAttributes'] = $this->modx->getOption('linkAttributes',$scriptProperties,'').' rel="lightbox[album]"';
It might be nice to include this change to a release version so that it does not have to be changed every time one manipulates with Gallery.

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 15, 2022
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant