Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

renderFormElements for richtext no longer showing existing content for some external modules #364

Closed
jasonabird opened this issue Nov 10, 2014 · 3 comments
Closed

renderFormElements for richtext no longer showing existing content for some external modules #364

jasonabird opened this issue Nov 10, 2014 · 3 comments

Comments

@jasonabird
Copy link
Contributor

Some modules (specifically mxCalendar) that uses renderFormElements no longer shows existing content in richtext fields.
jasonabird added a commit to jasonabird/evolution that referenced this issue Nov 10, 2014
@jasonabird
[modxcms#364] Fixed issue for renderFormElements to provide default t…
6d799af 
…ext even if @@eval is not present
@Jako
Copy link
Contributor

Jako commented Nov 10, 2014

There is a bug in your code: $field_value should be only $default_text if $field_value is empty.

The original code was changed from something like this:
$field_value = ($field_value != '') ? $field_value : $default_text;

jasonabird added a commit to jasonabird/evolution that referenced this issue Nov 12, 2014
@jasonabird
[modxcms#364] Fixed to only set value if field_value is empty
fb32017
@jasonabird
Copy link
Contributor Author

Great catch. Updated with that fix and validated also fixes for external modules such as mxcalendar that was using renderFormElements.

Jako added a commit that referenced this issue Nov 12, 2014
@Jako
Merge pull request #365 from jasonabird/develop
56cf31d 
[#364] Fixed issue for renderFormElements to provide default text even if @@eval is not present
Dmi3yy added a commit that referenced this issue Jan 28, 2015
@Dmi3yy
Merge branch 'develop' into ee
621a43c 
* develop: (24 commits)
  Adding HTML5 input types
  Update eform.inc.php
  Refactor - $modx->evalSnippets()
  Refactor - $modx->getTagsFromContent()
  Updated Languages from Transifex
  [+] phpthumb: encode only returned filenames
  [+] Install:  styles for component names and description
  [+] Display TV name during install
  [*] &q=96 makes no sense with png and gif (should be 100 there – or better not provided)
  [+] phpthumb encode decode cyr filenames
  [+] Ukrainian characters
  Updated Languages from Transifex
  [+] phpthumb: determination of the original image file extension
  [*] word boundary do NOT working with utf8 on some servers Php5.2.17, PCRE version 8.20 2011-10-21 Compiled with UTF-8 support Unicode properties support
  [+] Ukrainian characters
  [+] array version of #1 and #2 - in_array() used
  Fixing PHP 5.2 issues with transalias plugin
  + The “OnMakeDocUrl” event has been added. The event is invoked while making an URL with “$modx->makeUrl” and “$modx->makeFriendlyURL”.
  * The “$modx->makeUrl” method has been updated: minor code style changes. * The “$modx->makeFriendlyURL” method has been updated: minor code style changes.
  [#364] Fixed to only set value if field_value is empty
  ...
@MrSwed
Copy link
Contributor

MrSwed commented Nov 30, 2016

@@eval stopped working
need check again

reverts: #1016

@Dmi3yy Dmi3yy closed this as completed Jul 15, 2017
Deesen pushed a commit to Deesen/evolution that referenced this issue Jan 7, 2018
@64j
fix modxcms#364
9e07e88
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Jako @Dmi3yy @jasonabird @MrSwed