Ensure $restarted in templates/language.tpl always exists #12847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing 2 E_NOTICE errors being triggered when opening the setup and landing on the ?action=set step. See modxcms#12846 for details.
| @@ -37,5 +37,8 @@ | |||
| if (!empty($_REQUEST['restarted'])) { | |||
| $parser->set('restarted',true); | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
Maybe to simplify a little?
$parser->set('restarted', !empty($_REQUEST['restarted']));
|
@Mark-H will you please update the PR with the suggestion? |
|
@theboxer Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
Makes sure the $restarted variable in templates/language.tpl always exists. If it wasn't set, it would trigger two E_NOTICE errors.
Why is it needed ?
Make sure the setup doesn't throw any E_NOTICE errors
Related issue(s)/PR(s)
#12846