Minimize/maximize triangle icon small bug in the tree

[Ruslan-Aleev]

Summary

The icon appears in rows elements, resource folders and categories even if they are empty.
It's hard to understand are there row has any items until you click on all.

Step to reproduce

You can create an empty source of files, display it in the tree - the icon will appear, it will disappear when you click on the source, but if you refresh the page - it will appear again.

This behavior also happens in rows elements, resource folders, context and categories, perhaps
somewhere else.

MODX Revolution 2.6.5
Google Chrome 68.0.3440.106
Firefox 61.0.2

[OptimusCrime]

This issue has been posted before. I was unable to find the duplicate. The reason for this is pretty simple, and the fix is pretty difficult. Basically, there is no way of knowing if the expand/collapse button should be displayed before you inspect the contents of the directory. This check has to be executed for each directory in the current directory you are browsing. One PR was prepared that fixed this, but the delay the fix introduced led to it being declined for inclusion. For S3 buckets especially, the latency added was very noticable.

Based on that, I think this is an issue we have to live with, unless we have changed our minds since then.

[Jako]

@OptimusCrime Could that check run only on local file sources?

[OptimusCrime]

Here is the original issue #13166 and PR #13337.

[Ruslan-Aleev]

@OptimusCrime Thanks for the detailed answer, I now understand the logic of the menu, speed is more important :)
p.s. I should close the issue, or leave it open, can someone notice and offer a non-standard solution?

[OptimusCrime]

Lets see if someone "in charge" has something to say 😄

Just leave it open for now.

[alroniks]

We can leave it open but the fix should be provided only for local file systems as Mark suggested in discussions here #13337. Also, performance results should be provided.

[Ruslan-Aleev]

@alroniks Then should visually identify non-local sources: add some symbol (with Title attribute), color or icon to the non-local source in the header - otherwise it's very difficult to understand the logic to minimize/maximize, will seem like an obvious bug.
Maybe visually identify already done, did not use non-local sources.

Or leave everything as is :)