Refactored tag input renreder to fix rendering with empty options list #14319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jako
reviewed
Feb 1, 2019
| 'value' => htmlspecialchars($itemValue,ENT_COMPAT,'UTF-8'), | ||
| 'text' => htmlspecialchars($item,ENT_COMPAT,'UTF-8'), | ||
| 'checked' => $checked, | ||
| list($label, $meaning) = $option; |
There was a problem hiding this comment.
Why not $value and $text? The variables are only used for placeholder values afterwards and could use their name.
There was a problem hiding this comment.
$value already comes as the function parameter, I can not redefine it in the loop. About text yes, makes sense but label and meaning look more like a pair that text and meaning.
There was a problem hiding this comment.
Oh, I did not see that.
Meaning is somehow the wrong word. What about $tagText and $tagValue?
There was a problem hiding this comment.
$inputOptionTextand $inputOptionValue?
Jako
added
bug
Mark-H
previously approved these changes
Feb 4, 2019
|
Hi @Mark-H I've improved wording in variables a bit, please approve it again when you'll able to. |
JoshuaLuckers
approved these changes
Feb 4, 2019
Mark-H
approved these changes
Feb 5, 2019
Mark-H
added
pr/ready-for-merging
alroniks
pushed a commit
that referenced
this pull request
Feb 5, 2019
#14319] * upstream/pr/14319: Improve wording in variables Refactored tag input renreder to fix rendering with empty options list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It fixes the issue with displaying tag input component (TV) when options list set as empty.
Why is it needed?
It needed to avoid glitches that described in the issue.
Related issue(s)/PR(s)
#14177