Fixed a broken MODX browser for mobile screens #14774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruslan-Aleev
changed the title
JoshuaLuckers
approved these changes
Oct 1, 2019
JoshuaLuckers
added
type-frontend
|
Is this really fixing behavior that once worked but no longer does? Or is this making the MODX browser work on mobile screens for the first time? |
|
Browser did not work in my opinion, from the first versions where the adaptive appeared, 2.6 or earlier. Browser started working for the first time, at least I don’t remember that it worked at all. |
theboxer
added
pr/ready-for-merging
|
@opengeek is it ok with you if we merge this into 2.x? :) |
|
@JoshuaLuckers , I adjusted the styles of the icons in the tree, did it more correctly than before. Test please. |
JoshuaLuckers
added
pr/review-needed
Ibochkarev
approved these changes
Dec 1, 2019
opengeek
added a commit
that referenced
this pull request
Jan 10, 2020
Merge remote-tracking branch 'origin/pr/14774' into 2.x * origin/pr/14774: Fixed some styles (icons in the tree, progress bar) Fixed styles for buttons Fixed some styles Fixed a broken MODX browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixed the broken MODX browser and fixed some styles for mobile screens.
The browser styles, of course, is not perfect, but at least it works.
Related issue(s)/PR(s)
None