You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #14806, a new column is dynamically added to all (incl third party) grids, with a width of 50.
Works great, until you're loading a third party grid that is not defined in "pixel-ish" values, but in "percentage-ish". Because widths are relative to the total, one could be defining grid columns with widths of "0.2", "0.5", "0.3" for a total of 1, and ExtJS will calculate that to the proper pixel values on render.
Now imagine what that looks like when a magic column with a default width of 50 is added... your total is 51, 50 of which goes to the gear icon.
Step to reproduce
Install an extra that defines "percentage-ish" widths for columns instead of "pixel-ish". I ran across it with ClientConfig's admin view, but I'm sure there are others.
Observed behavior
Expected behavior
I'm not quire sure - mostly posting this to see what others and in particular @theboxer think. It's a simple fix, where the extra can define the width of the column (config.actionsColumnWidth)... but maybe there are some bright ideas on other solutions.
Environment
3.x branch from today
The text was updated successfully, but these errors were encountered:
@Mark-H I'm still not 100% sold on if the new "gear" column should be enabled by default...
And to the issue with percentages: Adding a config to be able to define own width is fairly simple and I'd add it for sure. We can also try to guess if you're using percentage based width (I actually never used it, and from a quick look at ClientConfig, it seems that we can check if width of every column is < 1, correct me if my thinking is wrong please) and use a default percentage with as well.
Must be enabled by default. Without the new context menu, it’s not at all clear that the elements in the grid can be changed, you can find out only by accident, probably :) especially if you are just starting to work with MODX.
And for mobile versions, too, because on mobile devices there is no right mouse button.
Bug report
Summary
In #14806, a new column is dynamically added to all (incl third party) grids, with a width of 50.
Works great, until you're loading a third party grid that is not defined in "pixel-ish" values, but in "percentage-ish". Because widths are relative to the total, one could be defining grid columns with widths of "0.2", "0.5", "0.3" for a total of 1, and ExtJS will calculate that to the proper pixel values on render.
Now imagine what that looks like when a magic column with a default width of 50 is added... your total is 51, 50 of which goes to the gear icon.
Step to reproduce
Install an extra that defines "percentage-ish" widths for columns instead of "pixel-ish". I ran across it with ClientConfig's admin view, but I'm sure there are others.
Observed behavior
Expected behavior
I'm not quire sure - mostly posting this to see what others and in particular @theboxer think. It's a simple fix, where the extra can define the width of the column (
config.actionsColumnWidth
)... but maybe there are some bright ideas on other solutions.Environment
3.x branch from today
The text was updated successfully, but these errors were encountered: