Fix JS TypeError if image/file TV fails validation, preventing error popup from showing [Rebuild] #15282
Conversation
…reventing error popup from showing
```
modx.panel.js:405 Uncaught TypeError: Cannot read property 'hidden' of undefined
at MODx.panel.Resource.showErroredTab (modx.panel.js:405)
at MODx.panel.Resource.fn (modx.panel.resource.js:25)
at h.Event.fire (ext-all.js:21)
at MODx.panel.Resource.fireEvent (ext-all.js:21)
at MODx.toolbar.ActionButtons.handleClick (modx.component.js:298)
at S.onClick (ext-all.js:21)
at HTMLSpanElement.I (ext-all.js:21)
```
|
Not disputing this, but I want to replicate it to get a better understanding of the case. Can you detail how you make this error happen? |
|
If you're not seeing it when a tv is required and uncategorized, I'll have to double-check. |
|
Yeah, I've tried with a bunch of scenarios (tvs below, above, only uncategorized, categorized and uncategorized) but can't seem to get the error to pop up. |
|
Okay, it looks to be specific to the image and file TV types and the categorisation isn't relevant - with an image/file TV that has allow blank disabled, the error does not popup and it does not open the right TV (sub)tab, wether that's uncategorized or something else. Changing the TV to a text/number/date/richtext input while keeping allowBlank disabled makes it work as expected. TVs are in the standard tab. |
Mark-H
changed the title
Mark-H
changed the title
What does it do?
Prevent JS error if an image/file tv fails validation.
Why is it needed?
On 2.8.0 saving an image/file tv that is required (allow blank = no) results in:
This avoids the js error, allowing the popup to be shown.
Related issue(s)/PR(s)
#15146