Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODX\Revolution\Rest\modRestClient::__construct is deprecated #15469

Closed
Ibochkarev opened this issue Mar 5, 2021 · 2 comments
Closed

MODX\Revolution\Rest\modRestClient::__construct is deprecated #15469

Ibochkarev opened this issue Mar 5, 2021 · 2 comments
Assignees
@JoshuaLuckers
Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
MODX 3.0.0-alpha MODX Revolution Beta 1
Milestone
v3.0.0-alpha3

Comments

@Ibochkarev
Copy link
Collaborator

Bug report

Summary

Error MODX\Revolution\Rest\modRestClient::__construct is deprecated

Step to reproduce

Set log_level to 4.
Open Extras -> Installer

Open MODX error log.

It should be clear.

Observed behavior

Errors:

[2021-03-05 15:08:29] (ERROR in xPDO\xPDO::getService @ /home/s22270/www/core/vendor/xpdo/xpdo/src/xPDO/xPDO.php : 1253) MODX\Revolution\Rest\modRestClient::__construct is deprecated since version 2.3.0. Use the modRest classes instead.
[2021-03-05 15:08:29] (ERROR in MODX\Revolution\Rest\modRestCurlClient::__construct @ /home/s22270/www/core/src/Revolution/Rest/modRestCurlClient.php : 31) MODX\Revolution\Rest\modRestClient::__construct is deprecated since version 2.3.0. Use the modRest classes instead.
[2021-03-05 15:08:29] (ERROR in xPDO\xPDO::getService @ /home/s22270/www/core/vendor/xpdo/xpdo/src/xPDO/xPDO.php : 1253) MODX\Revolution\Rest\modRestClient::__construct is deprecated since version 2.3.0. Use the modRest classes instead.
[2021-03-05 15:08:29] (ERROR in MODX\Revolution\Rest\modRestCurlClient::__construct @ /home/s22270/www/core/src/Revolution/Rest/modRestCurlClient.php : 31) MODX\Revolution\Rest\modRestClient::__construct is deprecated since version 2.3.0. Use the modRest classes instead.

Related issue(s)/PR(s)

NA

Environment

MODX Revolution 3.0.0-alpha3 (git), PHP Version 7.4.12
@Ibochkarev Ibochkarev added this to the v3.0.0-alpha3 milestone Mar 5, 2021
@Ibochkarev Ibochkarev added pr/review-needed Pull request requires review and testing. and removed pr/review-needed Pull request requires review and testing. labels Mar 5, 2021
@Ibochkarev
Copy link
Collaborator Author

@JoshuaLuckers You don't mind fixing it? =)

@JoshuaLuckers
Copy link
Contributor

It's on my todo list

@rthrash rthrash added this to 📥 Backlog in MODX 3.0.0-alpha Mar 11, 2021
@alroniks alroniks added bug The issue in the code or project, which should be addressed. area-core labels Apr 3, 2021
@rthrash rthrash added this to 📥 Backlog in MODX Revolution Beta 1 Apr 12, 2021
This was referenced Jul 29, 2021
Merged
Merged
MODX Revolution Beta 1 automation moved this from 📥 Backlog to Done 🎉 Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaLuckers JoshuaLuckers

Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
MODX Revolution Beta 1
Done 🎉
MODX 3.0.0-alpha
  
📥 Backlog
Milestone
v3.0.0-alpha3
Development

No branches or pull requests
3 participants
@alroniks @JoshuaLuckers @Ibochkarev