Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Region IDs in Customization Forms more understandable #16054

Open
Ruslan-Aleev opened this issue Feb 11, 2022 · 3 comments
Open

Make Region IDs in Customization Forms more understandable #16054

Ruslan-Aleev opened this issue Feb 11, 2022 · 3 comments
Labels
area-fc Work related to form customization rules feature Request about implementing a brand new function or possibility. proposal Proposal about improvement aka RFC. Need to be discussed before start implementation.
Milestone

Comments

@Ruslan-Aleev
Copy link
Collaborator

Ruslan-Aleev commented Feb 11, 2022

Feature request

Summary

In the Customization Forms regions ID has incomprehensible logic, as it seems to me.

For example:

  • modx-resource-settings and modx-page-settings, why 2? In my opinion modx-resource-settings is not used at all.
  • There are seemingly clear areas - modx-resource-main-left, modx-resource-main-right; modx-page-settings-left and modx-page-settings-right. But then an incomprehensible fragmentation begins: modx-resource-main-right-top, modx-resource-main-right-middle and modx-resource-main-right-bottom, although the region on the left does not have splitting into top/middle/bottom.
    modx-page-settings-* has modx-page-settings-box-left and modx-page-settings-box-right - now boxes appeared.

Why is it so difficult?

Suggested solution(s)

I propose to create a fixed number of regions (2 columns by 3 rows) for "Resource", "Settings" and "TV":

modx-resource-main
-- modx-resource-main-left
--- modx-resource-main-left-top
--- modx-resource-main-left-middle
--- modx-resource-main-left-bottom
-- modx-resource-main-right
--- modx-resource-main-right-top
--- modx-resource-main-right-middle
--- modx-resource-main-right-bottom

modx-resource-settings
-- modx-resource-settings-left
--- modx-resource-settings-left-top
--- modx-resource-settings-left-middle
--- modx-resource-settings-left-bottom
-- modx-resource-settings-right
--- modx-resource-settings-right-top
--- modx-resource-settings-right-middle
--- modx-resource-settings-right-bottom

modx-resource-tv
-- modx-resource-tv-left
--- modx-resource-tv-left-top
--- modx-resource-tv-left-middle
--- modx-resource-tv-left-bottom
-- modx-resource-tv-right
--- modx-resource-tv-right-top
--- modx-resource-tv-right-middle
--- modx-resource-tv-right-bottom

Or we can make 3 columns by 3 rows (left-to-right: left, middle, right; top-down: top, middle, bottom).

Related issue(s)/PR(s)

#13968
#16052
#14226

@Ruslan-Aleev Ruslan-Aleev added proposal Proposal about improvement aka RFC. Need to be discussed before start implementation. feature Request about implementing a brand new function or possibility. area-fc Work related to form customization rules labels Feb 11, 2022
@Ruslan-Aleev Ruslan-Aleev added this to the v3.1.0 milestone Feb 11, 2022
@SnowCreative
Copy link
Contributor

  • modx-resource-settings is not used at all.

I use modx-resource-settings frequently to add TVs to the Document tab if I need to put them under both of the columns instead of inside one of the columns. This way, I can add full-width richtext fields there, for example. In some cases, I have resources that use a lot of custom text fields, and not the main Content field. Since there is no way to put TVs in the Content area when the content field itself is turned off, modx-resource-settings is the only way to do this.

@Ruslan-Aleev
Copy link
Collaborator Author

Ruslan-Aleev commented Feb 25, 2022

Yes, I was wrong, modx-resource-setting can be used.
But in general, this is an issue about consistency, i.e. If there were regions with a clear name, it would be easier.

@SnowCreative
Copy link
Contributor

If there were regions with a clear name, it would be easier.

Yes, agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-fc Work related to form customization rules feature Request about implementing a brand new function or possibility. proposal Proposal about improvement aka RFC. Need to be discussed before start implementation.
Projects
None yet
Development

No branches or pull requests

2 participants