Rename the lexicon key and text of mail_smtp_prefix #16062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibochkarev
approved these changes
Feb 18, 2022
theboxer
approved these changes
Feb 18, 2022
Ibochkarev
added
pr/ready-for-merging
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/2023-how-to-setup-modx-3-0-3-pl-to-send-emails-via-formular/6582/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Change the lexicon key and text for
mail_smtp_prefixWhy is it needed?
The current text is a bit misleading. This setting sets the value of
SMTPSecurein PHPMailer 6. The description in PHPMailer isWhat kind of encryption to use on the SMTP connection.Related issue(s)/PR(s)
Improved version of #15527 (renaming the key too). Supercedes #15555 (see the discussion there).