Ensure modHashing::getHash is limited to modHash instances #16320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also brings tests for this file to 100% as a test for codecov. :D
Codecov ReportBase: 16.91% // Head: 16.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16320 +/- ##
=========================================
Coverage 16.91% 16.91%
- Complexity 10446 10447 +1
=========================================
Files 561 561
Lines 38028 38028
=========================================
+ Hits 6432 6433 +1
+ Misses 31596 31595 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Makes sure the requested modHash implementation is actually a modHash implementation, right now it can instantiate any class.
Also brings tests for this file to 100% as a test for codecov. :D
Why is it needed?
Wanted to make sure codecov works properly. Found issue writing test. Win.
How to test
Covered by tests.
Related issue(s)/PR(s)
#16317