Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login button in manager login form is not displayed #16572

Open
al5040 opened this issue May 14, 2024 · 1 comment
Open

Login button in manager login form is not displayed #16572

al5040 opened this issue May 14, 2024 · 1 comment
Labels
bug The issue in the code or project, which should be addressed.

Comments

@al5040
Copy link

al5040 commented May 14, 2024

Bug report

Summary

When using extras that improve security, such as captcha and TwoFactorX, the maximum height of the manger login form prevents the login button from being displayed.

Step to reproduce

Install captcha and TwoFactorX extras, enable both and change language in the login form for instance to German.

Observed behavior

Login button button no longer visible.

Expected behavior

Login Button should be visible. If I deactivate the css-setting max-height: 50rem of .can-toggle in the file /manager/templates/default/css/login-min.css, the button becomes visible.

Environment

MODX 3.0.5-pl, activated captcha and TwoFactorX extra for manager login, Firefox 125.0.3

Screenshot 2024-05-14 at 19-46-06 Login MODX Revolution

@al5040 al5040 added the bug The issue in the code or project, which should be addressed. label May 14, 2024
@smg6511
Copy link
Collaborator

smg6511 commented May 24, 2024

I was looking into how to fix this and it's tricky, at least if trying to stick within the current design. The issue really points to a need to re-think the UI/design of the login page so it can accommodate additional login security/features in an elegant way. The Login button is accessible by scrolling/swiping down, but it is certainly not ideal to have it below the fold—particularly on devices larger than a phone where there's plenty of space to work with.

That said, I don't think I'd consider this a bug, per se. If we had the label "UI Improvement" or something of the like, that'd be more what I'd call this request.

I can draw up some ideas if folks are open to this page being redesigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

2 participants