xpdo::getOption performance improvement #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great optimization. I wonder what impact skipping the check altogether would really have... |
|
I've done some testing with an simplified version without all te checks and server response times are ca. 40-50% of the original response times! |
|
New simplified version (improves server response times ca. 60% compared to original code) |
|
This is merged into 2.x, 2.4.x and 3.x — nice optimization and thanks again for the excellent contribution! |
opengeek
added a commit
that referenced
this pull request
Sep 22, 2015
Merge remote-tracking branch 'origin/pr/75' into 2.4.x * origin/pr/75: xpdo::getOption fix skipEmpty logic (v3: performance tweak) xpdo::getOption fix skipEmpty logic (v2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only call more expensive function 'array_key_exists' when 'isset' fails, leads to ca 15-20% performance increases for server response time in our specific modx site.
(skipping 'array_key_exists' leads to an extra 5-10% performance increase but would change the result if the value is null)