This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Configuring environment variable for port, plus bugfix for #3 PR #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 14, 2017 13:31
this dependency adds the function to globally set an header
|
I've deployed this app on heroku for test. Is unstable to run "docker image build" (the image will be created but the app will fail to start onto the container) but is safe to run it on heroku. |
| @@ -5,7 +5,7 @@ | |||
| "email": "moebiusmania@gmail.com" | |||
| }, | |||
| "engines": { | |||
| "node": "8.5.0" | |||
| "node": "^8.5.0" | |||
There was a problem hiding this comment.
remove caret plz, fixed version number is better 😉
There was a problem hiding this comment.
without the caret it will run only on node 8.5.0, not on 8.5.1 or 8.9.1, isn't more safe to allow to use the last version of the major?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the environment variable PORT for handling the server port (now it can run on Heroku or Docker) plus added a fix for pr #3