Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from requests to curl_cffi + enable Deezer #26

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Migrate from requests to curl_cffi + enable Deezer #26

merged 3 commits into from
Mar 8, 2024

Conversation

deedy5
Copy link
Contributor

@deedy5 deedy5 commented Mar 7, 2024 •
edited

  1. 馃憤 migrate from requests to curl_cffi 馃憤,
  2. enable Deezer provider,
  3. init session inside LRCProvider.init(),
  4. cli: add choices to -p parameter,
  5. update typing annotations,
  6. tests: add deezer testing.

deedy5 and others added 2 commits March 7, 2024 22:10
@deedy5
1) migrate from requests to curl_cffi,
17dfcad 
2) enable Deezer provider,
3) init session inside LRCProvider.__init__(),
4) cli: add choices to -p parameter,
5) update typing annotations,
6) tests: add deezer testing.
@moehmeni
Update tests.py
6c688ce 
The first argument of `os.getenv` is the environment variable key name. The second value is the default value if the key is not set in the environment.
@moehmeni
Copy link
Owner

moehmeni commented Mar 8, 2024

Thanks for the contribution.
Everything looks great, so using curl_cffi solved the Deezer problem?! do you know why if yes?

@deedy5
Copy link
Contributor Author

deedy5 commented Mar 8, 2024

https://github.com/yifeikong/curl_cffi

Unlike other pure python http clients like httpx or requests, curl_cffi can impersonate browsers' TLS/JA3 and HTTP/2 fingerprints. If you are blocked by some website for no obvious reason, you can give curl_cffi a try.

@moehmeni moehmeni merged commit 7341137 into moehmeni:main Mar 8, 2024
6 checks passed
@deedy5 deedy5 deleted the dev branch March 8, 2024 15:47
@moehmeni moehmeni mentioned this pull request Mar 8, 2024
Closed
moehmeni added a commit that referenced this pull request Mar 8, 2024
@moehmeni
Use parser choices to filter providers (#26)
b108908 
See 0e99113#commitcomment-139566554 for more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deedy5 @moehmeni