Sort observers when initializing OrbitDeterminationObservations for I…

…OD and OD (#160)
moeyensj · Feb 12, 2024 · 997c399 · 997c399
1 parent 215c4e3
commit 997c399
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/thor/orbits/iod.py b/thor/orbits/iod.py
@@ -149,10 +149,21 @@ def iod_worker(
             pc.is_in(observations.id, obs_ids)
         )
 
+        # Sort observations by time
+        observations_linkage = observations_linkage.sort_by(
+            [
+                "coordinates.time.days",
+                "coordinates.time.nanos",
+                "coordinates.origin.code",
+            ]
+        )
+
         observations_linkage = OrbitDeterminationObservations.from_kwargs(
             id=observations_linkage.id,
             coordinates=observations_linkage.coordinates,
-            observers=observations_linkage.get_observers().observers,
+            observers=observations_linkage.get_observers().observers.sort_by(
+                ["coordinates.time.days", "coordinates.time.nanos", "code"]
+            ),
         )
 
         iod_orbit, iod_orbit_orbit_members = iod(

diff --git a/thor/orbits/od.py b/thor/orbits/od.py
@@ -54,10 +54,21 @@ def od_worker(
         ).obs_id
         orbit_observations = observations.apply_mask(pc.is_in(observations.id, obs_ids))
 
+        # Sort observations by time
+        orbit_observations = orbit_observations.sort_by(
+            [
+                "coordinates.time.days",
+                "coordinates.time.nanos",
+                "coordinates.origin.code",
+            ]
+        )
+
         orbit_observations = OrbitDeterminationObservations.from_kwargs(
             id=orbit_observations.id,
             coordinates=orbit_observations.coordinates,
-            observers=orbit_observations.get_observers().observers,
+            observers=orbit_observations.get_observers().observers.sort_by(
+                ["coordinates.time.days", "coordinates.time.nanos", "code"]
+            ),
         )
 
         od_orbit, od_orbit_orbit_members = od(