Do a better job at filtering duplicate numbers

moezbhatti · Feb 6, 2020 · e47bfb5 · e47bfb5
1 parent bf808a8
commit e47bfb5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/data/src/main/java/com/moez/QKSMS/repository/SyncRepositoryImpl.kt b/data/src/main/java/com/moez/QKSMS/repository/SyncRepositoryImpl.kt
@@ -276,16 +276,16 @@ class SyncRepositoryImpl @Inject constructor(
                     val uniqueNumbers = mutableListOf<PhoneNumber>()
                     contacts.value
                             .flatMap { it.numbers }
-                            .sortedBy { it.accountType }
                             .forEach { number ->
                                 number.isDefault = defaultNumberIds.any { id -> id == number.id }
-                                val duplicate = uniqueNumbers.any { other ->
-                                    number.accountType != other.accountType
-                                            && phoneNumberUtils.compare(number.address, other.address)
+                                val duplicate = uniqueNumbers.find { other ->
+                                    phoneNumberUtils.compare(number.address, other.address)
                                 }
 
-                                if (!duplicate) {
+                                if (duplicate == null) {
                                     uniqueNumbers += number
+                                } else if (!duplicate.isDefault && number.isDefault) {
+                                    duplicate.isDefault = true
                                 }
                             }