Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard not dismissed automatically #937

Closed
ohodovaniuk opened this issue Mar 18, 2018 · 3 comments
Closed

Keyboard not dismissed automatically #937

ohodovaniuk opened this issue Mar 18, 2018 · 3 comments
Assignees
Labels

Comments

@ohodovaniuk
Copy link

ohodovaniuk commented Mar 18, 2018

DESCRIPTION

When you input data into the edit text field and then you decide to go back to parent view, you click on back arrow inside the toolbar (top right corner). However, the child to parent redirection animation is faster then the hide keyboard animation, therefore you have this behavior:

As you can see even when the parent view is already displayed the keyboard is still visible for less than a second.

STEPS TO REPRODUCE

  • Open conversation view
  • Tap search icon
  • Tap the edit text field (if keyboard is not visible)
  • Click the back arrow to go back to the previous view

NOTE

I have also observed this behavior in other views that have child-parent redirection, so i think it would be nice to deal with this issue to have better animation and user experience. I have an idea how to fix this, so i would also like to claim this issue. Will provide you with a pull request soon.

@moezbhatti
Copy link
Owner

Can you verify if you still experience this issue using QKSMS 3?

@ohodovaniuk
Copy link
Author

I have just build the QKSMS 3 and i noticed that the design changed and the search works differently (no need to go back to the parent anymore). However, i have also noticed that the keyboard newer closes if i switch from chat list view to new chat view and vise versa. The keyboard is always there. Is that expected behavior? It looks like you want the keyboard to be always visible in the chat list view and the search onfocus, but when i decide to close the keyboard than switch the views the keyboard is there again. Not sure if that's a bug or something you have consciously decided to implement.

@moezbhatti moezbhatti changed the title Keyboard does not hide fast enough when the back button is pressed Keyboard not dismissed when going back to conversation list Apr 5, 2018
@moezbhatti moezbhatti self-assigned this Apr 5, 2018
@moezbhatti moezbhatti changed the title Keyboard not dismissed when going back to conversation list Keyboard not dismissed automatically Apr 5, 2018
@moezbhatti moezbhatti added the bug label Apr 5, 2018
@moezbhatti moezbhatti added this to To do in Issue tracker Apr 5, 2018
@moezbhatti moezbhatti moved this from To do to Up next in Issue tracker Apr 5, 2018
@moezbhatti
Copy link
Owner

Fixed in 2e91937

Issue tracker automation moved this from Up next to Done (3.0.6) Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants