Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop IncomingMessage and just fix MailRequest #40

Closed
moggers87 opened this issue Jan 6, 2016 · 0 comments
Closed

Drop IncomingMessage and just fix MailRequest #40

moggers87 opened this issue Jan 6, 2016 · 0 comments
Milestone
3.0.0

Comments

@moggers87
Copy link
Owner

So after some thinking and playing around with the current Salmon in master, I've decided to see if I can get the same result (being able to access a plain Python email message without any double processing) without too much trouble.

Currently looking at attaching a reference to the corresponding Mime part on MailBase and making header/body decoding lazy
@moggers87 moggers87 added this to the Salmon-next milestone Jan 6, 2016
moggers87 added a commit that referenced this issue Jan 9, 2016
@moggers87
Turn salmon.encoding.MailBase into a wrapper
bd5f3a7 
So far this seems to be a better solution that "filters"

touch #40
moggers87 added a commit that referenced this issue Jan 9, 2016
@moggers87
Update changelog
710ebb5 
touch #40
moggers87 added a commit that referenced this issue Jan 9, 2016
@moggers87
Remove IncomingMessage
32d25a4 
touch #40
moggers87 added a commit that referenced this issue Jan 9, 2016
@moggers87
Fix charset in spam examples
1936a3c 
We should be checking bad-email tolerance elsewhere

touch #40
moggers87 added a commit that referenced this issue Jan 10, 2016
@moggers87
Don't add Mime-Version to everything
570582a 
touch #40
moggers87 added a commit that referenced this issue Jan 10, 2016
@moggers87
Refactor test_to_message_from_message_with_spam
2db2a1f 
Other than known idiosyncrasies (certain content headers being set
explicitally where they were implicit in the original message), we don't
expect there to be any differences between `m` and `m2` - we certainly
don't expect any `EncodingError`s!

touch #40
@moggers87 moggers87 mentioned this issue Mar 10, 2016
Closed
@moggers87 moggers87 mentioned this issue Dec 16, 2017
Closed
moggers87 added a commit that referenced this issue Dec 17, 2017
@moggers87
Change MailRequest.Email back to MailRequest.base
29ee8f9 
This was missed in #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@moggers87