Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 fixes #74

Merged
merged 3 commits into from
May 25, 2018
Merged

PEP8 fixes #74

merged 3 commits into from
May 25, 2018

Conversation

moggers87
Copy link
Owner

Fixes #73 and many other PEP8 violations.

Still keeping the 120 char limit though.

@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #74 into master will decrease coverage by 0.09%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #74     +/-   ##
=========================================
- Coverage   95.45%   95.36%   -0.1%     
=========================================
  Files          12       12             
  Lines        1386     1380      -6     
=========================================
- Hits         1323     1316      -7     
- Misses         63       64      +1
Impacted Files Coverage Δ
salmon/bounce.py 100% <ø> (ø) ⬆️
salmon/view.py 100% <ø> (ø) ⬆️
salmon/handlers/forward.py 100% <100%> (ø) ⬆️
salmon/handlers/log.py 83.33% <100%> (ø) ⬆️
salmon/utils.py 90.27% <100%> (ø) ⬆️
salmon/commands.py 91.98% <100%> (-0.07%) ⬇️
salmon/mail.py 100% <100%> (+0.64%) ⬆️
salmon/encoding.py 95.97% <100%> (+0.01%) ⬆️
salmon/confirm.py 96.77% <100%> (ø) ⬆️
salmon/server.py 91.07% <33.33%> (-0.06%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a5bec...9bea825. Read the comment docs.

@moggers87 moggers87 force-pushed the 73-mailrequest-str-defined-twice branch from 6474f6f to ee9f036 Compare May 25, 2018 05:50
@moggers87 moggers87 force-pushed the 73-mailrequest-str-defined-twice branch from ee9f036 to 9bea825 Compare May 25, 2018 06:39
@moggers87 moggers87 merged commit 902959b into master May 25, 2018
@moggers87 moggers87 deleted the 73-mailrequest-str-defined-twice branch May 25, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants