Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(user-service): rewrite user service as a microservice #348

Merged
merged 20 commits into from
Sep 12, 2022

Conversation

wibus-wee
Copy link
Member

@wibus-wee wibus-wee commented Sep 10, 2022

# start app in watching mode
nest start -w user-service

此 PR 需完成什么

  • 获取用户信息
  • 新用户注册
  • 用户更新信息
  • 用户登出(全部/部分登出)
  • 用户登录
  • 获取全部已登入且有效的会话

Route Preview

需要注意什么

  • 并没有做_角色控制_功能,此功能经过商讨决定日后功能稳定后再做。
  • 后续需要接入 Core,由 Core 公开接口。
  • 错误捕捉尚未完善,另起 PR
  • 虽然看样子 gateway 层已暴露接口,但实际不可用

@wibus-wee wibus-wee self-assigned this Sep 10, 2022
@wibus-wee wibus-wee added enhancement New feature or request module/user Questions or Anything for User Module WIP PRs in WIP labels Sep 10, 2022
@wibus-wee wibus-wee added bug Something isn't working and removed bug Something isn't working WIP PRs in WIP labels Sep 11, 2022
@wibus-wee wibus-wee marked this pull request as ready for review September 11, 2022 01:53
@wibus-wee
Copy link
Member Author

rxjs有throwError方法,为什么不使用 catchError 来捕捉错误?而是直接让整一个方法返回可以称之为unhandled的错误

@MYXXTS
Copy link
Contributor

MYXXTS commented Sep 12, 2022

从上至下从一开始
1和2的接口url是否应该变化一下
5和6的区别在哪里?
7和8的区别在哪里?

@wibus-wee
Copy link
Member Author

从上至下从一开始
1和2的接口url是否应该变化一下
5和6的区别在哪里?
7和8的区别在哪里?

1和2你觉得变成什么好?

5和6的话..5是登出某一个会话,6是登出全部会话

7和8是我搞错了,应该就一个8的

@MYXXTS
Copy link
Contributor

MYXXTS commented Sep 12, 2022

修改的话加个相应的英文前缀
某个会话和全部会话能否举例
7和8请尽快修改

@wibus-wee
Copy link
Member Author

修改的话加个相应的英文前缀
某个会话和全部会话能否举例
7和8请尽快修改

会话..就是比如你iMac上登录了后台就是一个会话了,在MacBook上也登录了后台这是另外一个会话

@wibus-wee
Copy link
Member Author

信息 info information 好像没问题?(逃)

@MYXXTS
Copy link
Contributor

MYXXTS commented Sep 12, 2022

ok会话明白了
修改的比如getinfo、changeinfo之类的,我英语不是很好

@wibus-wee
Copy link
Member Author

ok会话明白了 修改的比如getinfo、changeinfo之类的,我英语不是很好

似乎一般都不会这么写,这个接口的请求方法就决定了到底是 GetInfo 还是 UpdateInfo

@MYXXTS
Copy link
Contributor

MYXXTS commented Sep 12, 2022

ok,也只是建议,其余的要是没什么我就marge了

@wibus-wee
Copy link
Member Author

改好了之前 7和8的问题

@MYXXTS
Copy link
Contributor

MYXXTS commented Sep 12, 2022

ok

@wibus-wee
Copy link
Member Author

wibus-wee commented Sep 12, 2022

ok,也只是建议,其余的要是没什么我就marge了

好,你得先approve才能merge的应该😂

@MYXXTS MYXXTS merged commit a4c1dbf into main Sep 12, 2022
@MYXXTS MYXXTS deleted the refactor/user-service branch September 12, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module/user Questions or Anything for User Module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants