Merge pull request #706 from mogol/juliansteenbakker-patch-1

Update flutter_drive.yml
mogol · May 8, 2024 · bf74b32 · bf74b32
2 parents c0b716c + 0f549b6
commit bf74b32
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/.github/workflows/flutter_drive.yml b/.github/workflows/flutter_drive.yml
@@ -2,26 +2,31 @@ name: integration test
 on: [pull_request]
 jobs:
   drive_android:
-      runs-on: macos-latest
+      runs-on: ubuntu-latest
       steps:
         - uses: actions/checkout@v4
         - uses: subosito/flutter-action@v2.16.0
         - uses: actions/setup-java@v3
           with:
             distribution: 'temurin'
             java-version: '17'
-        - name: "Run Flutter Driver tests API 18"
+        - name: Enable KVM
+          run: |
+            echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
+            sudo udevadm control --reload-rules
+            sudo udevadm trigger --name-match=kvm
+        - name: "Run Flutter Driver tests API 19"
           uses: reactivecircus/android-emulator-runner@v2
           with:
-            api-level: 18
+            api-level: 19
             target: default
             arch: x86
             script: "cd example && flutter drive --target=test_driver/app.dart"
             working-directory: ./flutter_secure_storage
-        - name: "Run Flutter Driver tests API 33"
+        - name: "Run Flutter Driver tests API 34"
           uses: reactivecircus/android-emulator-runner@v2
           with:
-            api-level: 33
+            api-level: 34
             target: google_apis
             arch: x86_64
             script: "cd example && flutter drive --target=test_driver/app.dart"

diff --git a/flutter_secure_storage/android/build.gradle b/flutter_secure_storage/android/build.gradle
@@ -30,15 +30,15 @@ android {
         buildConfig = true
     }
 
-    compileSdkVersion 33
+    compileSdk 34
 
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
     }
 
     defaultConfig {
-        minSdkVersion 18
+        minSdkVersion 19
     }
 
 }

diff --git a/flutter_secure_storage/example/android/app/build.gradle b/flutter_secure_storage/example/android/app/build.gradle
@@ -25,7 +25,7 @@ apply plugin: 'com.android.application'
 apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
 
 android {
-    compileSdk 33
+    compileSdk 34
     ndkVersion flutter.ndkVersion
 
     compileOptions {
@@ -35,8 +35,8 @@ android {
 
     defaultConfig {
         applicationId "com.it_nomads.fluttersecurestorageexample"
-        minSdkVersion 18
-        targetSdkVersion 33
+        minSdkVersion 19
+        targetSdkVersion 34
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName
     }