Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with AGP 8.0 #560

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

Almighty-Alpaca
Copy link
Contributor

@Almighty-Alpaca Almighty-Alpaca commented May 1, 2023

See flutter/flutter#125181 and flutter/flutter#125621 (comment) for more information

Fixes #559 and fixes #557

@CodeDoctorDE
Copy link

Looks like this repo is not very active?

@ghost
Copy link

ghost commented May 31, 2023

@juliansteenbakker :)

@olaripihlak
Copy link

@juliansteenbakker ,would be awesome if you could merge that :)

@juliansteenbakker
Copy link
Collaborator

Sorry for the very late response! LGTM!

@juliansteenbakker juliansteenbakker merged commit bb3b811 into mogol:develop Jun 27, 2023
@josephcrowell
Copy link

josephcrowell commented Jul 3, 2023

@juliansteenbakker Could you also push out an 8.x.x release which includes this fix? TIA

@pitw
Copy link

pitw commented Jul 17, 2023

As as workaround until @juliansteenbakker pushed the fixes to main branch import secure storage with this:

    git:
      url: https://github.com/mogol/flutter_secure_storage.git
      ref: develop
      path: ./flutter_secure_storage```

@Almighty-Alpaca Almighty-Alpaca deleted the fix/agp-8.0 branch August 15, 2023 22:37
@incon
Copy link

incon commented Aug 22, 2023

A new release with this fix would be awesome :)

@matanshukry matanshukry mentioned this pull request Aug 25, 2023
@kevtechi
Copy link

@juliansteenbakker , a release of this would be greatly appreciated. Was forced to upgrade kotlin and gradle today. Can't compile Android without manually modifying this project's build.gradle file.

@josephcrowell
Copy link

@juliansteenbakker , a release of this would be greatly appreciated. Was forced to upgrade kotlin and gradle today. Can't compile Android without manually modifying this project's build.gradle file.

@pitw's fix works temporarily until julian pushes out a build with the fix.

@kevtechi
Copy link

@juliansteenbakker , a release of this would be greatly appreciated. Was forced to upgrade kotlin and gradle today. Can't compile Android without manually modifying this project's build.gradle file.

@pitw's fix works temporarily until julian pushes out a build with the fix.

Sure, I just wouldn't recommend pointing to the develop branch for production apps as we don't know when something will merge and behavior could change.

Maybe the commit instead, so at least it stays stable?

git:
      url: https://github.com/mogol/flutter_secure_storage.git
      ref: bb3b811
      path: ./flutter_secure_storage

@juliansteenbakker
Copy link
Collaborator

Sorry for the huge delay, fixed in v8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android native plugin doesn't support AGP 8.0 Add compatibility with AGP 8 (Android Gradle Plugin)
8 participants