Feature - Check availability of protected data on iOS and macOS #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tinoProtectedDataAvailable
This reverts commit bdb5e55.
gnunicorn
reviewed
Oct 9, 2023
flutter_secure_storage/ios/Classes/SwiftFlutterSecureStoragePlugin.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Kampmann <ben.kampmann@gmail.com>
|
Looks good to me, thanks for your work! |
|
Is this available in the public package version 9.0.0? |
|
@bogdannedelcu looks like it isn't right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #602 this PR adds the bridge to
isProtectedDataAvailableon macOS(12.0 and newer) and iOS. It also adds the possiblity to get notified when availability of the protected data will change. At the moment listening toapplicationProtectedDataDidBecomeAvailableandapplicationProtectedDataWillBecomeUnavailableis only possible on iOS. Support for macOS is currently blocked by PR flutter/engine#44587 not beeing in the current flutter stable version.As soon as a new major stable version of flutter gets released we could add support for macOS.
Combined with PR #602 this fixes #524.