Skip to content

Commit

Permalink
Merge pull request #24 from mogproject/dev
Browse files Browse the repository at this point in the history
Dev
  • Loading branch information
mogproject committed Apr 30, 2022
2 parents 1af8415 + d9ba142 commit c67a2a0
Show file tree
Hide file tree
Showing 8 changed files with 78 additions and 59 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
@@ -1,7 +1,7 @@
language: node_js

node_js:
- 'node'
- 17

script:
- npm run coverage
Expand Down
17 changes: 13 additions & 4 deletions assets/css/yay-filter.css
Expand Up @@ -4,10 +4,10 @@
height: 23px;
color: var(--yt-spec-text-secondary);
font-family: Roboto, Arial, sans-serif;
font-size: var(--ytd-tab-system_-_font-size);
font-weight: var(--ytd-tab-system_-_font-weight);
letter-spacing: var(--ytd-tab-system_-_letter-spacing);
text-transform: var(--ytd-tab-system_-_text-transform);
font-size: var(--ytd-tab-system-font-size);
font-weight: var(--ytd-tab-system-font-weight);
letter-spacing: var(--ytd-tab-system-letter-spacing);
text-transform: var(--ytd-tab-system-text-transform);

user-select: none;
-webkit-user-select: none;
Expand All @@ -22,6 +22,15 @@
margin-top: 46px !important;
opacity: 0;
transition: opacity 0.3s;
font-size: var(--ytd-thumbnail-attribution_-_font-size);
font-weight: var(--ytd-thumbnail-attribution_-_font-weight);
line-height: var(--ytd-thumbnail-attribution_-_line-height);
letter-spacing: var(--ytd-thumbnail-attribution_-_letter-spacing);
text-transform: var(--ytd-thumbnail-attribution_-_text-transform);
background-color: var(--paper-tooltip-background, #616161);
color: var(--paper-tooltip-text-color, white);
padding: 8px;
border-radius: 2px;
}

#yay-filter-container:hover .yay-tooltip {
Expand Down
2 changes: 1 addition & 1 deletion assets/manifest_chrome.json
@@ -1,7 +1,7 @@
{
"manifest_version": 2,
"name": "Yet Another YouTube Comment Filter",
"version": "0.1.5",
"version": "0.2.0",
"description": "Filters comments on YouTube.",
"author": "Yosuke Mizutani",

Expand Down
2 changes: 1 addition & 1 deletion assets/manifest_firefox.json
@@ -1,7 +1,7 @@
{
"manifest_version": 2,
"name": "Yet Another YouTube Comment Filter",
"version": "0.1.5",
"version": "0.2.0",
"description": "Filters comments on YouTube.",
"author": "Yosuke Mizutani",

Expand Down
99 changes: 50 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "yay-filter",
"version": "0.1.5",
"version": "0.2.0",
"description": "Yet another YouTube comment filter",
"devDependencies": {
"@types/chrome": "0.0.127",
Expand Down
9 changes: 9 additions & 0 deletions src/App.ts
Expand Up @@ -113,6 +113,8 @@ export default class App {
* @param url URL to check
*/
private verifyUrl(url: string): void {
// this.log(`verifyUrl(${url})`);

if (url != Config.url.targetUrl) throw new UnexpectedUrlError(url);
}

Expand Down Expand Up @@ -169,10 +171,13 @@ export default class App {

// check if it already exists (this can happen by a browser's "go back" button, etc.)
const e = DomManager.findCommentHeader();
// this.log(String(e));
if (e != null) return Promise.resolve(e);

const p = new Promise<HTMLElement>((resolve, reject) => {
const observer = new MutationObserver((m, o) => {
// this.log('observer call');

// check if the comment header exists
const elem = DomManager.findCommentHeader();
if (elem == null) return;
Expand All @@ -181,10 +186,12 @@ export default class App {
o.disconnect();

// return element
// this.log('observer finds element');
resolve(elem);
});
observer.observe(commentContainer, { subtree: false, childList: true });
});
// this.log('watching: ' + String(commentContainer.outerHTML));
return p;
}

Expand Down Expand Up @@ -248,6 +255,8 @@ export default class App {
* Clears the filter button.
*/
private clearYayFilterContainer(): void {
// this.log(`clearYayFilterContainer()`);

const elem = DomManager.findYayFilterContainer();
if (elem != null) {
elem.remove();
Expand Down
4 changes: 2 additions & 2 deletions src/Config.ts
Expand Up @@ -6,7 +6,7 @@
declare const __DEBUG__: string;

export const Config = {
version: '0.1.5',
version: '0.2.0',
url: {
targetUrl: 'www.youtube.com/watch',
projectUrl: 'https://github.com/mogproject/yay-filter',
Expand All @@ -21,7 +21,7 @@ export const Config = {
},
selector: {
// YouTube selector queries
ytCommentContainer: 'ytd-comments #header.ytd-item-section-renderer',
ytCommentContainer: '#primary ytd-comments #header.ytd-item-section-renderer',
ytCommentTitle: 'ytd-comments #title.ytd-comments-header-renderer',
ytCommentContents: 'ytd-comments #contents.ytd-item-section-renderer',
ytCommentThread: 'ytd-comments ytd-comment-thread-renderer',
Expand Down

0 comments on commit c67a2a0

Please sign in to comment.