Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for the URL parsing in ogm/config. #134

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

obi1kenobi
Copy link
Contributor

Config mis-parsed URL strings, transforming URLs such as localhost:2424/db_name to:

ParseResult(scheme='localhost', netloc='', path='2424/db_name', params='', query='', fragment='')

This obviously results in a failure to connect to the DB.

@obi1kenobi
Copy link
Contributor Author

The CI failure seems to be due to a transient OrientDB connection error -- none of the functionality I changed was called in the problematic test cases. Can I somehow cause CI to re-run without pushing again?

@Ostico
Copy link
Collaborator

Ostico commented Oct 23, 2015

No, you can't because you haven't admin access to the repo. I run it again
for you.
Il 23 ott 2015 9:40 PM, "Predrag Gruevski" notifications@github.com ha
scritto:

The CI failure seems to be due to a transient OrientDB connection error --
none of the functionality I changed was called in the problematic test
cases. Can I somehow cause CI to re-run without pushing again?


Reply to this email directly or view it on GitHub
#134 (comment).

@obi1kenobi
Copy link
Contributor Author

Thanks, much appreciated! Looks good now!

mogui added a commit that referenced this pull request Nov 2, 2015
Added a fix for the URL parsing in ogm/config.
@mogui mogui merged commit dfc61b7 into mogui:develop Nov 2, 2015
@obi1kenobi obi1kenobi deleted the config_url_fix branch November 2, 2015 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants