Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of multiple level exceptions in message header #255

Merged
merged 1 commit into from Sep 2, 2017

Conversation

kived
Copy link

@kived kived commented Sep 1, 2017

Fixes #197. The serialized exception appears only once, after the list of class/message pairs.

Also changes the generated Python exception message to be more readable.

Previous:
pyorient.exceptions.PyOrientCommandException: com.orientechnologies.orient.core.exception.OValidationExceptionjava.lang.NumberFormatException - impossible to convert value of field "coordinates"For input string: "UNKNOWN"

New:
pyorient.exceptions.PyOrientCommandException: com.orientechnologies.orient.core.exception.OValidationException - impossible to convert value of field "coordinates", java.lang.NumberFormatException: For input string: "UNKNOWN"

@coveralls
Copy link

coveralls commented Sep 1, 2017

Coverage Status

Coverage decreased (-0.5%) to 77.195% when pulling 9b6dfb7 on ijettech-dev:fix-exception-handling into 7535abe on mogui:master.

@kived kived changed the base branch from master to develop September 1, 2017 22:16
@TropicalPenguin TropicalPenguin merged commit 59871f5 into mogui:develop Sep 2, 2017
@TropicalPenguin
Copy link
Collaborator

Thanks!

@kived kived deleted the fix-exception-handling branch September 5, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants