Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign2: add assignment 2 solution #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

assign2: add assignment 2 solution #29

wants to merge 1 commit into from

Conversation

sameem420
Copy link

No description provided.

mohammadrajabraza
mohammadrajabraza requested changes Sep 12, 2021
View reviewed changes
Copy link
Owner

@mohammadrajabraza mohammadrajabraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! However you need to update commit message like git commit -m "assign1: add assignment 1 solution" as advised in the issue

@sameem420 sameem420 changed the title Assignment 2 solution added assign2: add assignment 2 solution Sep 23, 2021
@sameem420
Copy link
Author

Good work! However you need to update commit message like git commit -m "assign1: add assignment 1 solution" as advised in the issue

Sir If I did now, I have to added files again. I will keep in mind and do it the same way next time.Thanks

@mohammadrajabraza mohammadrajabraza added the hacktoberfest-accepted Fulfill the acceptance criteria label Oct 27, 2021
@mohammadrajabraza
Copy link
Owner

No, you won't have to add files. Just reset --soft this commit and commit again with the new commit message. these changes are required to merge your changes in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadrajabraza mohammadrajabraza mohammadrajabraza requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted Fulfill the acceptance criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sameem420 @mohammadrajabraza