Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment 3: MongoDB CRUD Operations #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YAHYA-YOUNAS
Copy link

adding assignment 3 solution

Copy link
Owner

@mohammadrajabraza mohammadrajabraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@mohammadrajabraza mohammadrajabraza added the first submission First assignment submission label Oct 12, 2021
@mohammadrajabraza
Copy link
Owner

I would recommend you to participate in the Hacktoberfest 2021 and follow the contribution instructions from there for this PR.

@YAHYA-YOUNAS YAHYA-YOUNAS changed the title assign3: added assignment 3 solution Assignment 3: MongoDB CRUD Operations Oct 21, 2021
@mohammadrajabraza mohammadrajabraza added the hacktoberfest-accepted Fulfill the acceptance criteria label Oct 27, 2021
#[tokio::main]
async fn main() -> mongodb::error::Result<()> {
// Making Database connection
let mut client_options = ClientOptions::parse("mongodb://vidly-user:12345@vidly-shard-00-00.ypxnu.mongodb.net:27017,vidly-shard-00-01.ypxnu.mongodb.net:27017,vidly-shard-00-02.ypxnu.mongodb.net:27017/vidly?ssl=true&replicaSet=atlas-1437c6-shard-0&authSource=admin&retryWrites=true&w=majority").await?;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove credentials (i.e. username and password) from this DB_URL?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done sir!

Copy link
Owner

@mohammadrajabraza mohammadrajabraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. But why didn't you push change in a single commit?

@YAHYA-YOUNAS
Copy link
Author

Sir I did a single commit. Only I changed the heading of Pull Request online.

@mohammadrajabraza
Copy link
Owner

What I mean to say is now your PR consist of 2 commits look here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first submission First assignment submission hacktoberfest-accepted Fulfill the acceptance criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants