Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: everyNDays(days: 5) doesn't work #12

Closed
lorderetik opened this issue Feb 21, 2024 · 2 comments · Fixed by #15
Closed

[Bug]: everyNDays(days: 5) doesn't work #12

lorderetik opened this issue Feb 21, 2024 · 2 comments · Fixed by #15
Labels
bug Something isn't working

Comments

@lorderetik
Copy link

What happened?

Create event for date 2024-02-19 15:30 every 5 days.
whereOccurresOn(Carbon::make('2024-02-29'))->get(); returns empty, but it should repeat event in this date

How to reproduce the bug

Create event for date 2024-02-19 15:30 every 5 days.

Package Version

0.5.1

PHP Version

8.2

Laravel Version

10.43

Which operating systems does with happen with?

Linux

Notes

Also it doesn't work for events that have duration more than one day, for example, start date 2024-02-19 15:30, end date 2024-02-22 17:30

@lorderetik lorderetik added the bug Something isn't working label Feb 21, 2024
@rappasoft
Copy link

Also having this issue.

@EriBloo
Copy link
Contributor

EriBloo commented Apr 4, 2024

Hi,
This is not due to everyNDays(days: 5) or 2024-02-29 being leep day, but because you also provide the time (basically this would work, if you did whereOccurresOn(Carbon::make('2024-02-29 15:30'))->get();). This should be fixed if this PR is merged.

mohammedmanssour added a commit that referenced this issue May 10, 2024
Fix Issue #12 + Add Issue #4 + cleanup repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants