Ensure Float64Array is supported #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

JackCA commented Mar 9, 2013

I encountered an issue while using this (awesome) library where Float32Array was supported while Float64Array was not. Specifically, in my headless Phantom.js integration tests. See this issue

I'm unsure how to run the tests for this library so apologies for not being able to check that, but this simple fix appears to be working just fine 🎸 🎷

Owner

mohayonao commented Mar 9, 2013

Thanks.

I think the Web Audio API is not available in phantom.js, do I need to support phantom.js?

Owner

mohayonao commented Mar 9, 2013

I have not written how to run the tests for this library yet.
I'm always checking in the following ways:

show document pages

$ cd timbre.js/build
$ node dev-server.coffee

open http://127.0.0.1:3000/timbre.js/

You can edit a document in the docs.md.

or

test with Mocha

$ cd timbre.js/test
$ mocha add.js

requires

  • node.js v0.8.x
  • express
  • jade
  • marked (0.2.6)
  • mocha
  • chai

JackCA commented Mar 9, 2013

No, I don't think you need to specifically support it -- it's just that all of my integration tests would fail immediately because of Float64Array being undefined. Other than that, I don't think there's any additional support needed.

On Sat, Mar 9, 2013 at 5:42 AM, mohayonao notifications@github.com
wrote:

Thanks.

I think the Web Audio API is not available in phantom.js, do I need to support phantom.js?

Reply to this email directly or view it on GitHub:
#2 (comment)

mohayonao added a commit that referenced this pull request Mar 9, 2013

Owner

mohayonao commented Mar 9, 2013

Your fixed affects built-in typed arrays (e.g. Float32Array), so I've subjected to another fix.
You can avoid to fail immediately.

@mohayonao mohayonao closed this Mar 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment