Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour guides in the scrollview are not showing #5

Closed
eugene-zheng0208 opened this issue Dec 7, 2017 · 4 comments
Closed

Tour guides in the scrollview are not showing #5

eugene-zheng0208 opened this issue Dec 7, 2017 · 4 comments
Labels

Comments

@eugene-zheng0208
Copy link

No description provided.

@cfnelson
Copy link
Contributor

cfnelson commented Dec 7, 2017

@eugene-zheng0208 Could you please provide some more details on the issue, a reproduction would be very helpful. Otherwise we wont be able to effectively assist you?

@eugene-zheng0208
Copy link
Author

We have a fixed navbar at the top of our screen, and scrolling to our next step which is now up the screen and under the navbar means only some of the dialog is highlighted instead of the full box. Is there a way to override the highlighted area with CSS so that we can move it down? Or add in that the page scrolls fully back to the top before selecting the next item in the joyride?

@mohebifar
Copy link
Owner

I believe having a stepChange hook would be helpful. We can save a reference to the scrollView, and use that in the stepChange event listener for scrolling to the right position. We can also use promises to delay showing the next step while it's scrolling.

  componentWillMount() {
    this.props.on('stepChange', ({ step }) => {
      if (step.name === 'StepWithScroll') {
        this.scrollView.scrollToEnd();
        return new Promise(r => setTimeout(r, 300));
      }
    });
  }

@eugene-zheng0208 What do you think?

@mohebifar
Copy link
Owner

We haven't heard back on this and there is also another issue for the same issue suggesting a solution: #15
Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants