Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copilot in a ScrollView #15

Open
thibautguedou3 opened this issue Feb 7, 2018 · 7 comments
Open

Use copilot in a ScrollView #15

thibautguedou3 opened this issue Feb 7, 2018 · 7 comments

Comments

@thibautguedou3
Copy link

We are currently using copilot in one of our project, we needed to add some features:

  • be able to highlight an element that is in a scrollView but not in visible on the screen (cf screenshot)
    ios - scroll on highlighted elements
  • customize the style of the CopilotStep

We have worked on an implementation of those features on a fork: https://github.com/bamlab/react-native-copilot

Could you look at it and tell us if we can make a Pull Request on your repo?

@RichardLitt
Copy link
Contributor

@mohebifar What do you think?

@mohebifar
Copy link
Owner

@thibautguedou3 This is indeed interesting! Could you please provide an example of the scroll view and how that is handled by copilot?

  • Is the position of the scroll view updated automatically?
  • Does the scroll view need to be the root copilot component or it can be descendant of it?

Also, I noticed that in your fork 's are replaced with " that may not match our linting rules.

@naffiq
Copy link
Contributor

naffiq commented Jul 17, 2018

Hi! I've been implementing tutorial in our app and have couple of suggestions to thread.
It might be better to consider more scenarios, like switching tabs and animating TextInput filling, that might need similar solution implementation.

Besides, we're using KeyboardAwareScrollView component (and I think many of others might) that might need customization at this point.

@AE0011
Copy link

AE0011 commented Nov 15, 2018

@thibautguedou3 how to use your fork?

@vokhuyetOz
Copy link

vokhuyetOz commented Aug 8, 2019

any update on this.

@rgordon95
Copy link

Would love to see these changes integrated so we can scroll within the tutorial.

@Usamaliaquat123
Copy link

Usamaliaquat123 commented Aug 23, 2021

try this

 componentDidMount() {
    // Starting the tutorial and passing the scrollview reference.
    this.props.start(false, this.scrollView);
  }

  componentWillUnmount() {
    // Don't forget to disable event handlers to prevent errors
    this.props.copilotEvents.off("stop");
  }

  render() {
    <ScrollView ref={ref => (this.scrollView = ref)}>// ...</ScrollView>;
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants