This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
Compile the project against Play 2.4.0-RC3 to fix binary incompatibil… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was not as simple as I initially expected. Working on fixing the tests. |
|
|
||
| libraryDependencies ++= Seq( | ||
| "com.googlecode.htmlcompressor" % "htmlcompressor" % "1.5.2", | ||
| "rhino" % "js" % "1.7R2" | ||
| ) | ||
|
|
||
| lazy val root = (project in file(".")).enablePlugins(PlayScala) | ||
| libraryDependencies += specs2 % Test |
There was a problem hiding this comment.
Please could you add this dependency to the dependency list above.
|
Thanks for your work on this. Looks good to me expect the parts I've commented. Could you please squash the commits into a single commit after you have updated the changes. |
…ities introduced in new Play version #35
| "rhino" % "js" % "1.7R2" | ||
| "rhino" % "js" % "1.7R2", | ||
| specs2 % Test, | ||
| "org.easytesting" % "fest-assert" % "1.4" % Test |
There was a problem hiding this comment.
I thought this is not needed?
There was a problem hiding this comment.
The dependency appears to have been removed from the default set
akkie
added a commit
that referenced
this pull request
May 27, 2015
Compile the project against Play 2.4.0-RC3 to fix binary incompatibil…
|
@raelg Thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ities introduced in new Play version #35