This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
Don't try to compress gzipped assets. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filter tries to compress any assets with 'Content-Type: text/html'. When using with sbt-gzip pipeline stage, the Assets controller will serve pre-gzipped assets. The pre-gzipped assets have the text/html content type, therefore the HtmlCompressorFilter picks them up. This PR skips pre-gzipped assets by checking 'Content-Encoding: gzip' header.
akkie
added a commit
that referenced
this pull request
Oct 1, 2015
Don't try to compress gzipped assets.
|
Thanks, very nice 👍 |
|
Any time! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter tries to compress any assets with 'Content-Type: text/html'.
When using with sbt-gzip pipeline stage, the Assets controller will
serve pre-gzipped assets. The pre-gzipped assets have the text/html
content type, therefore the HtmlCompressorFilter picks them up.
This PR skips pre-gzipped assets by checking 'Content-Encoding: gzip'
header.