This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
Tests for CredentialsProvider #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fernandoacorreia I've changed the return type from
Future[Option[LoginInfo]]toFuture[Try[LoginInfo]]becauseNonedoesn't describe the occurred error. The other alternative would be to return only aFuture[LoginInfo]and throw Exceptions in case of an error, pretty much as we do it for all social providers. But I'm not sure if we should go this way, because the API doesn't describe that an error can occur. And in this case the error is an integral part of the authentication flow.The other question is now, should we change the return type of the social providers too? So that the API describes also that an error can occur during authentication?