This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
Consider to also return the AuthInfo from the providers #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation we do not return the
AuthInfo
from the providers, instead the providers stores the information after a successful authentication. I think this is a problem if a user uses a relational database with referential integrity to store the data, because the authentication information gets stored before the user will be stored. Maybe we should also return theAuthInfo
from the provider and then delegate the storage of the data to the user.What do you think @fernandoacorreia?