Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Consider to also return the AuthInfo from the providers #147

Merged
merged 1 commit into from
Mar 26, 2014
Merged

Consider to also return the AuthInfo from the providers #147

merged 1 commit into from
Mar 26, 2014

Conversation

akkie
Copy link
Contributor

@akkie akkie commented Mar 26, 2014

In the current implementation we do not return the AuthInfo from the providers, instead the providers stores the information after a successful authentication. I think this is a problem if a user uses a relational database with referential integrity to store the data, because the authentication information gets stored before the user will be stored. Maybe we should also return the AuthInfo from the provider and then delegate the storage of the data to the user.

What do you think @fernandoacorreia?

akkie added a commit that referenced this pull request Mar 26, 2014
Consider to also return the AuthInfo from the providers
@akkie akkie merged commit ea3b16f into mohiva:master Mar 26, 2014
@fernandoacorreia
Copy link
Contributor

I'm still not sure if the OAuth providers' AuthInfo should be persisted at all. I've been focusing mostly on the CredentialsProvider, but in the future I hope to come back to this issue and either come to the same conclusion as you (that it needs to be persisted) or argue that it doesn't.

@akkie
Copy link
Contributor Author

akkie commented Apr 26, 2014

With the current implementation the user can decide himself if the data should be persisted or not. With the old implementation this wasn't possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants