Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Update REST seed with Silhouette 2.0 #289

Closed
wants to merge 1 commit into from
Closed

Update REST seed with Silhouette 2.0 #289

wants to merge 1 commit into from

Conversation

julien-lafont
Copy link
Contributor

Hello,

I've updated the Silhouette-rest-seed to works with Silhouette 2.0.
I've tried to follow the way you develop the official seed.

The main difference is that I've removed the social things. I don't see in a REST API why we would like to connect with a social provider.
But If someone think it's important, I will accept PR gladly.

If you have any comment about the seed, just tell me, I can update it :)

@coveralls
Copy link

Coverage Status

Coverage increased (+1.08%) to 100.0% when pulling 3347203 on studiodev:patch-1 into 76bb34c on mohiva:master.

@akkie
Copy link
Contributor

akkie commented Feb 21, 2015

@StudioDev This template wasn't developed by me but rather by @merle-. And I'm not sure if I should really replace this example with yours without asking @merle-. I hope you can understand this. So @merle- would it be OK to replace your example? We can also add a new example.

@julien-lafont
Copy link
Contributor Author

Yes of course I understand.

If @merle- want to continue to maintain this seed, I would gladly sent a PR to this project instead of linking my repository.

@datalek
Copy link

datalek commented Feb 21, 2015

Thanks @akkie and @StudioDev, I've planned to update the example within this weekend, i'm going to use Cake Pattern for DI so i think that we could have two different example, one that use Guice for Dependency Injection and one that use Cake Pattern. Also i would like to cover link feature with other social profile and add a mail service.

@julien-lafont
Copy link
Contributor Author

Ok, sorry for the misunderstanding.

@akkie I can rename my seed "silhouette-minimal-rest-seed" so that you could publish it in addition of merle one, which will follow another approach.

Is it ok for you two?

@akkie
Copy link
Contributor

akkie commented Feb 21, 2015

Sure, why not!

@julien-lafont
Copy link
Contributor Author

I will do another one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants