This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
BasicAuthProvider should check the method is Basic #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this issue when I send requests where the Authorization header was a JWT Bearer such as:
When the
BasicAuthProvider
tries to parse the credentials it Base64 decodes"Bearer eyJ0eXAiOiJKV1Q..."
and since the resulting string has a:
in it thinks it's a Basic Auth header. This PR makes sure the header is Basic Auth and returnsNone
otherwise.