Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Allow to return a Future in the Authorization.isAuthorized method #340

Merged
merged 1 commit into from
May 11, 2015

Conversation

GonzaGonza
Copy link
Contributor

isAuthorized method use Futures, so now it is possible to avoid Await when you use a DB (like MongoDb) to know if a user is authorized.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.24% when pulling fafd8a6 on GonzaGonza:master into 3c860cf on mohiva:master.

@akkie
Copy link
Contributor

akkie commented May 10, 2015

Really nice! But please could you rewrite the commit message into something like this: Allow to return a Future in the Authorization.isAuthorized method

@GonzaGonza
Copy link
Contributor Author

Sure i will rewrite it, and re-do the pullrequest. Thanks!

UPDATE Done. I edited the commit message to: Allow to return a Future in the Authorization.isAuthorized method

On Sun, May 10, 2015, 3:49 AM Christian Kaps notifications@github.com
wrote:

Really nice! But please could you rewrite the commit message into
something like this: Allow to return a Future in the
Authorization.isAuthorized method


Reply to this email directly or view it on GitHub
#340 (comment)
.

@GonzaGonza GonzaGonza changed the title isAuthorized Future Support Allow to return a Future in the Authorization.isAuthorized method May 10, 2015
akkie added a commit that referenced this pull request May 11, 2015
Allow to return a Future in the Authorization.isAuthorized method
@akkie akkie merged commit 6eaf894 into mohiva:master May 11, 2015
@akkie
Copy link
Contributor

akkie commented May 11, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants